ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vivek Ratnavel <vivekratnave...@gmail.com>
Subject Re: Add reviewers to PR as a non-committer?
Date Wed, 17 Jan 2018 19:51:46 GMT
Hi Jason,

Thanks for bringing this up. For contributors, the best way to notify
people would be to tag them in comments. This is another good reason to add
[component] tags to the PR title, so that committers who are working on
those components can pro-actively take a look at the newly opened pull
requests. The committers of the community should actively check newly
created PRs and resolve them. If the PR is not reviewed by any committer
for a long time, then the contributor can try pinging the committers by
tagging them in comments as I mentioned before. Relevant committers can be
found by doing a git blame on the files contributed in the patch.

Thanks,
Vivek Ratnavel

On Wed, Jan 17, 2018 at 11:33 AM, Jason Golieb <jgolieb@hortonworks.com>
wrote:

> As a non-committer, is it possible to add reviewers to a pull request? It
> doesn’t look like it to me. What’s the suggested procedure for getting eyes
> on my PRs?
>



-- 
-Vivek Ratnavel S

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message