ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jonathan Hurley <jhur...@hortonworks.com>
Subject Re: Add reviewers to PR as a non-committer?
Date Wed, 17 Jan 2018 20:00:33 GMT
We have a very active project with potentially dozens of new PRs coming in every day - I don't
think relying on the community to look is a very sustainable model. Is there no way to add
reviewers without tagging them? There seems to be a way to filter by reviews needing attention
- seems silly that non-committers can't add committers ... 

> On Jan 17, 2018, at 2:51 PM, Vivek Ratnavel <vivekratnavel90@gmail.com> wrote:
> 
> Hi Jason,
> 
> Thanks for bringing this up. For contributors, the best way to notify
> people would be to tag them in comments. This is another good reason to add
> [component] tags to the PR title, so that committers who are working on
> those components can pro-actively take a look at the newly opened pull
> requests. The committers of the community should actively check newly
> created PRs and resolve them. If the PR is not reviewed by any committer
> for a long time, then the contributor can try pinging the committers by
> tagging them in comments as I mentioned before. Relevant committers can be
> found by doing a git blame on the files contributed in the patch.
> 
> Thanks,
> Vivek Ratnavel
> 
> On Wed, Jan 17, 2018 at 11:33 AM, Jason Golieb <jgolieb@hortonworks.com>
> wrote:
> 
>> As a non-committer, is it possible to add reviewers to a pull request? It
>> doesn’t look like it to me. What’s the suggested procedure for getting eyes
>> on my PRs?
>> 
> 
> 
> 
> -- 
> -Vivek Ratnavel S

Mime
View raw message