ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ambari] akiyamaneko commented on a change in pull request #3243: [Ambari 25570] Fix HDFS Namenode page in grafana had some rpc metrics always show 'No datapoints' .
Date Thu, 22 Oct 2020 05:18:51 GMT

akiyamaneko commented on a change in pull request #3243:
URL: https://github.com/apache/ambari/pull/3243#discussion_r509885471



##########
File path: ambari-metrics/ambari-metrics-grafana/ambari-metrics/datasource.js
##########
@@ -273,7 +273,7 @@ define([
             }
             var metricTransform = !target.transform || target.transform === "none" ? '' :
'._' + target.transform;
             var seriesAggregator = !target.seriesAggregator || target.seriesAggregator ===
"none" ? '' : '&seriesAggregateFunction=' + target.seriesAggregator;
-            var templatedComponent = (_.isEmpty(tComponent)) ? target.app : tComponent;
+            var templatedComponent = (_.isEmpty(target.app)) ? tComponent : target.app;

Review comment:
       @payert  thanks for your suggesion, I have move the releated metrics from namenode
to datanodes page and munatal test screet shot also update. please help to review again. 😃

   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message