ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ambari] payert opened a new pull request #3242: AMBARI-25569 Reassess Ambari Metrics data migration
Date Mon, 12 Oct 2020 14:19:56 GMT

payert opened a new pull request #3242:
URL: https://github.com/apache/ambari/pull/3242


   ## What changes were proposed in this pull request?
   The data migration code only looks for the metrics that are present in the whitelist file.
This is true even in the case when the AMS Whitelisting is not enabled. The user will only
have those metrics migrated that are present in the whitelist file, which is usually not all
that are required.
   
   **The proposed change #1:**
   
   - If whitelist file parameter is provided then
       - migrate only the metrics that are in the whitelist file
   - if whitelist file parameter is not provided then
       - if whitelisting is enabled then
           - discover the whitelist file configured in AMS and
           migrate only the metrics that are in the whitelist file
       - if whitelisting is disabled then
           - migrate all the metrics present in the database
   
   **The proposed change #2:**
   Furthermore, the migration process frequently dies silently while saving the metadata.
To fix this, the change suggests removing the initiating of saving metadata from the shutdown
hook and call it "normally" in a _finally_ block.
   
   **The proposed change #3:**
   Code cleanup.
   
   ## How was this patch tested?
   The patch was tested by manual data migrations.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message