ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ambari] akiyamaneko opened a new pull request #3243: [Ambari 25570] Fix HDFS Namenode page in grafana had some rpc metrics always show 'No datapoints' .
Date Tue, 13 Oct 2020 09:36:29 GMT

akiyamaneko opened a new pull request #3243:
URL: https://github.com/apache/ambari/pull/3243


   ## What changes were proposed in this pull request?
   
   ### 1. Alter the metrics from `rpc.rpc.datanode.xx` to   `rpc.rpc.xx`
   
   The abnormal metrics in Granfana were defined as follows:
   
   metric | widget name
   -- | --
   rpc.rpc.**datanode**.RpcQueueTimeAvgTime | RPC Service Port Queue Time
   rpc.rpc.**datanode**.RpcQueueTimeNumOps | RPC Service Port Queue Ops
   rpc.rpc.**datanode**.RpcProcessingTimeAvgTime | RPC Service Port Processing Time
   rpc.rpc.**datanode**.RpcProcessingTimeNumOps | RPC Service Port Processing Num Ops
   rpc.rpc.**datanode**.CallQueueLength | RPC Service Port Call Queue Length
   rpc.rpc.**datanode**.RpcSlowCalls | RPC Service Port Port Slow Calls
   
   
   
   Granafa used  `rpc.rpc.datanode.xx` but in ams-hbase, they are stored with: `rpc.rpc.xx`:
   ![the metrics stored in ams-hbase](https://user-images.githubusercontent.com/52202080/95838641-98736980-0d74-11eb-9f23-7a5b701c534b.png)
   
   ![query by rest](https://user-images.githubusercontent.com/52202080/95839028-12a3ee00-0d75-11eb-94fa-467c4e33c47b.png)
   
   So I altered the metrics from `rpc.rpc.datanode.xx` to   `rpc.rpc.xx`
   
   ### 2. Adjusted the initialization of appid parameters
   The missing metircs belong to the DataNode, but the appId used by the Granafa is NameNode,
So these metircs cannot be displayed after step 1 above.  
   I changed the way to init appId in metric-url, if `app` element had been configured, used
custom app instead of global appId.
   
   ## How was this patch tested?
   manual test, I have tested the all metrics in namenode page and work well.
   ![munutal test](https://user-images.githubusercontent.com/52202080/95841711-43395700-0d78-11eb-92b7-93e6d1a05127.png)
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message