ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ambari] hapylestat commented on a change in pull request #3254: AMBARI-25569 Reassess Ambari Metrics data migration - 2nd part
Date Tue, 03 Nov 2020 19:42:33 GMT

hapylestat commented on a change in pull request #3254:
URL: https://github.com/apache/ambari/pull/3254#discussion_r516771850



##########
File path: ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/ambari/metrics/core/timeline/upgrade/core/AbstractPhoenixMetricsCopier.java
##########
@@ -53,7 +53,7 @@ public AbstractPhoenixMetricsCopier(String inputTableName, String outputTableNam
   @Override
   public void run(){
     LOG.info(String.format("Copying %s metrics from %s to %s", metricNames, inputTable, outputTable));
-    final long startTimer = System.currentTimeMillis();
+    final long st = System.currentTimeMillis();

Review comment:
       what is st?   can we rename it to something with more meaning like timerStart   and
estimatedTime for example to timerDelta




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message