ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ambari] hapylestat commented on a change in pull request #3275: AMBARI-25606. Sometimes request aborting doesn't abort IN_PROGRESS task.
Date Tue, 22 Dec 2020 13:40:46 GMT

hapylestat commented on a change in pull request #3275:
URL: https://github.com/apache/ambari/pull/3275#discussion_r547282896



##########
File path: ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java
##########
@@ -218,8 +218,10 @@ public Request getRequest(long requestId) {
 
     // only request commands which actually need to be aborted; requesting all
     // commands here can cause OOM problems during large requests like upgrades
+    List<HostRoleStatus> statusesToAbort = new ArrayList<>(HostRoleStatus.SCHEDULED_STATES);

Review comment:
       its better to create new constant for SCHEDULED_STATES + SCHEDULED_STATES instead of
combining them each time




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message