apr-bugs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 54572] New: [PATCH] move struct crypt_data allocation to heap in apr_password_validate
Date Sun, 17 Feb 2013 16:34:45 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=54572

            Bug ID: 54572
           Summary: [PATCH] move struct crypt_data allocation to heap in
                    apr_password_validate
           Product: APR
           Version: HEAD
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: minor
          Priority: P2
         Component: APR
          Assignee: bugs@apr.apache.org
          Reporter: rgacogne+asf@aquaray.com
    Classification: Unclassified

Created attachment 29959
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=29959&action=edit
[PATCH] move struct crypt_data allocation to heap in apr_password_validate

Hi,

When compiled with CRYPT_R_STRUCT_CRYPT_DATA defined, the apr_password_validate
function allocates a struct crypt_data variable on the stack. The crypt_data
struct is a GNU extension, whose glibc's version has a size of roughly 128k.

This patch against the apr trunk changes the stack-based allocation of this
variable to a heap-based one.

We use Apache HTTPd 2.2.23 / APR 1.4.6 with the worker mpm, and this function
was the only thing preventing us to set the ThreadStackSize at 128k (131072). I
am aware that some common modules are not playing well with such a low stack
size, but in our case everything is working fine with this patch applied.


Regards,

Remi Gacogne
Aqua Ray SAS

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@apr.apache.org
For additional commands, e-mail: bugs-help@apr.apache.org


Mime
View raw message