apr-bugs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 47630] NTFS Reparse Points are treated as n*x APR_LNK, only correct for junction/dir link
Date Wed, 27 Feb 2019 17:31:06 GMT

--- Comment #20 from William A. Rowe Jr. <wrowe@apache.org> ---
Oleg, thank you for your patch submission (comment #19).

This has taken me to revisit my original code to vet that we always
are using FindFile semantics when we need to consider the "is symlink?"
question. I should find enough cycles this week to complete that study.

The polymorphic treatment of FindFile and GetFileInfo return structures
proves to be a bit illegible, so I intend to use a union to better 
illustrate the distinctions and hopefully capture any misuse of uncommon 
members between the three structures.

Your patch appears to be 100% comprehensive, but is likely redundantly
testing the filename for fitness (this had to happen earlier in any case)
and the tests in the GetFileInfo case may be unnecessary, since I don't
believe we use that code path. If it is necessary to recall the reparse
tag type, DeviceIoControl should be a faster path than FindFile.

I'll try to get this research done promptly and advance this for 1.7.0.
This change may be too far out-of-scope for 1.6.6, since developers shouldn't
be exposed to major behavioral changes in subversion bumps. Other work on
APR suggests that 1.7.0 should be considered for release soon.

You are receiving this mail because:
You are the assignee for the bug.
To unsubscribe, e-mail: bugs-unsubscribe@apr.apache.org
For additional commands, e-mail: bugs-help@apr.apache.org

View raw message