aries-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Valentin Mahrwald (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ARIES-691) Add tests for EclipseLink - possibly include fragment for EclipseLink support
Date Wed, 06 Jul 2011 11:49:16 GMT

    [ https://issues.apache.org/jira/browse/ARIES-691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13060494#comment-13060494
] 

Valentin Mahrwald commented on ARIES-691:
-----------------------------------------

Hi Balazs,

thanks a lot for testing the changes on Glassfish and for the feedback. Highly appreciated.

Now, in terms of the issues you have found:
- javax.persistence imports absolutely should be able to handle minor version updates. Thanks
for spotting that.

- Handling RESOLVED Eclipselink bundles also makes sense. However, I think rather than starting
the Eclipselink bundle (which is slightly more invasive). I think loading the provider class
from the RESOLVED bundle and tracking it in case the Eclipselink bundle is unresolved / uninstalled
would be better !?

- I have found the same problem, which is why the OSGiTSServer is included now. This retrieves
a TransactionManager from the service registry. If that does not work or you want to use the
SunAS integration, I would suggest having the import on the persistence bundle rather than
the adapter bundle. The reasoning for this is that even when adding all the common server
packages from Eclipselink in this way we would not be able to support other providers and
they would have to be added in the persistence bundle's import anyway. So I would rather make
it consistent and have the responsibility for that import at the persistence bundle, which
also defines the dependency. 

- getBundleContext() returning null is a well-known "feature" of the OSGi Bundle API :) I
am afraid I am not clear though on where exactly this method gets called and how Blueprint
gets involved. Could you be more specific in where this interaction comes from and how it
goes wrong :)

I hope to commit a fix (based on your patch) for the first two issues either today or tomorrow.

Regards,

Valentin






> Add tests for EclipseLink - possibly include fragment for EclipseLink support
> -----------------------------------------------------------------------------
>
>                 Key: ARIES-691
>                 URL: https://issues.apache.org/jira/browse/ARIES-691
>             Project: Aries
>          Issue Type: Improvement
>          Components: JPA
>    Affects Versions: 0.4
>            Reporter: Timothy Ward
>            Assignee: Valentin Mahrwald
>             Fix For: 0.4
>
>         Attachments: eclipselinkadapter.patch
>
>
> We should test the Aries JPA container with EclipseLink as well as OpenJPA to give us
better coverage. This may involve writing code to expose the EclipseLink PersistenceProvider
implementation

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message