aries-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bas (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ARIES-1356) getInstance method on the core Activator shows up on jvisualvm sampling during performance analysis
Date Tue, 25 Aug 2015 12:01:46 GMT

    [ https://issues.apache.org/jira/browse/ARIES-1356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14711141#comment-14711141
] 

Bas commented on ARIES-1356:
----------------------------

Hi,

I'll give it a try. But probably it will stay of the radar of the sampler this time because
I estimate it will be efficient enough compared to how it used to be.

In the code I posted the thread protection is still there, there is just a double check for
it. If it thinks it is null it double checks it in a synchronized manner. Which should solve
threading issues right? (I might be wrong, but I don't see it now) 

The volatile way should also work, just less efficient probably compared to the double check
I think (if the double check solves the threading issues). But way better probably than it
used to be.

I didn't have debug level logging while doing the performance tests.


> getInstance method on the core Activator shows up on jvisualvm sampling during performance
analysis
> ---------------------------------------------------------------------------------------------------
>
>                 Key: ARIES-1356
>                 URL: https://issues.apache.org/jira/browse/ARIES-1356
>             Project: Aries
>          Issue Type: Improvement
>          Components: Subsystem
>    Affects Versions: subsystem-core-1.2.0, subsystem-2.0.1
>         Environment: Java windows linux
>            Reporter: Bas
>            Assignee: John Ross
>            Priority: Minor
>              Labels: patch, performance
>             Fix For: subsystem-core-1.2.0
>
>         Attachments: aries-1356.patch, subsystem-activator-patch.txt
>
>
> The 'getInstance' method on the core Activator shows up on jvisualvm sampling during
performance analysis.
> While doing performance analyses because of poor subsystem install performance while
running 200 subsystems we encountered the 'getInstance' method in jvisualvm statistics. It
is called so much that it actually cost 4 seconds on the total process of installing two subsystems
when 200 subsystems have been deployed already.
> While using the patch below we didn't notice it anymore in jvisualvm sampling.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message