aries-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sam Wright (JIRA)" <>
Subject [jira] [Closed] (ARIES-1481) blueprint-maven-plugin: fix detection of inherited @OsgiService/@PersistenceContext/Unit-annotated fields
Date Wed, 13 Jan 2016 17:15:40 GMT


Sam Wright closed ARIES-1481.

Thanks for merging this! I just checked out trunk - very nice refactorings. It looks much
better now that field-finding and method-finding is done in the one class.

> blueprint-maven-plugin: fix detection of inherited @OsgiService/@PersistenceContext/Unit-annotated
> ---------------------------------------------------------------------------------------------------------
>                 Key: ARIES-1481
>                 URL:
>             Project: Aries
>          Issue Type: Bug
>          Components: Blueprint
>            Reporter: Sam Wright
>            Assignee: Christian Schneider
>             Fix For: blueprint-maven-plugin-1.4.0
> Fields inherited from parent classes annotated with @Inject are properly detected by
blueprint-maven-plugin, but the presence of @OsgiService,
> @PersistenceContext, and @PersistenceUnit annotations on fields declared in parent classes
is ignored.
> This is because @Inject-annotated fields are found in the Bean.resolve(Matcher) method
which recursively searches all parent classes for declared fields, whereas @PersistenceContext/Unit-annotated
fields are discovered in Bean.getPersistenceFields() by simply using the fields declared in
the bean class. Similarly, @OsgiService-annotated fields are discovered in Context.addServiceRefs(Class)
by looking through the fields declared in the bean class.
> This commit extracts the field-getting algorithm used for finding
> @Inject fields to a utility method which is used for finding fields for the other
> annotations.

This message was sent by Atlassian JIRA

View raw message