aries-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Ross (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ARIES-1565) Performance Improvement: unpack subsystem artifacts to tmp folder to avoid directly reading from zip archive
Date Tue, 26 Jul 2016 12:04:20 GMT

    [ https://issues.apache.org/jira/browse/ARIES-1565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15393689#comment-15393689
] 

John Ross commented on ARIES-1565:
----------------------------------

Switching to Java 7 is not an option for at least some contributors and consumers.

It would certainly be easy to provide a naive implementation on 6, but there are a number
of issues to be considered when playing with subdirectories of the temp directory. See the
Files.createTempDir() Guava source code comments for more information. I would prefer to use
existing and hardened utilities for this if possible. I'm pretty sure the Apache 2.0 license
would allow us to simply copy that method from Guava as long as we provide the appropriate
attributions. Apache Commons does not have a utility for creating a temp directory. It does,
however, have an existing utility for deleting directories recursively. If I'm correct that
the Apache 2.0 license allows it, I would suggest copying it from there. Between those two
methods, we should have what we need in order to complete this.

> Performance Improvement: unpack subsystem artifacts to tmp folder to avoid directly reading
from zip archive
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: ARIES-1565
>                 URL: https://issues.apache.org/jira/browse/ARIES-1565
>             Project: Aries
>          Issue Type: Improvement
>          Components: Subsystem, Util
>    Affects Versions: subsystem-2.0.8, util-1.1.2
>            Reporter: Wouter Bancken
>         Attachments: 1565.patch, Call_Tree_2_0_8.html, Call_Tree_John_Ross.html, Call_Tree_Wouter_Bancken.html,
aries1565-profile.png, test-service-subsystem-4.0.2-SNAPSHOT.esa
>
>
> h4. Description
> Aries copies ESA archives to a temporary zip file during the installation phase. Afterwards,
bundles are read directly from this temporary zip which has a large impact on the startup
performance of Aries applications. By unpacking the esa artifact into the temporary folder
it is unpacked only once. Subsequent reads for the bundles (jars) can be read directly from
the folder. 
> h4. Pull request
> https://github.com/apache/aries/compare/subsystem-2.0.x...WouterBanckenACA:io_performance_optimalisation?expand=1
> h4. Mailinglist
> http://mail-archives.apache.org/mod_mbox/aries-user/201606.mbox/%3CCAL5nZgTq5FxDvURJbzcEZ9YHx6vTs3HAOuFYDYA3ec9OZbmwjA%40mail.gmail.com%3E



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message