aries-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ARIES-1634) BlueprintContainer are leaked when destroyed
Date Wed, 16 Nov 2016 18:42:58 GMT

    [ https://issues.apache.org/jira/browse/ARIES-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15671254#comment-15671254
] 

ASF GitHub Bot commented on ARIES-1634:
---------------------------------------

GitHub user adetalhouet opened a pull request:

    https://github.com/apache/aries/pull/58

    ARIES-1634 BlueprintContainer are leaked when destroyed

    While destroying the BlueprintContainer, the associated
    ServiceRegistration isn't unregistered, although it should
    be to completely release the BlueprintContainer.
    
    The #quiesce() method does that correctly, so current workaround
    is to first quiesce the bundle then destroy it. But it feels like
    an oversight in the #destroy() method.
    
    Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/adetalhouet/aries blueprint-container-leak

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/aries/pull/58.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #58
    
----
commit 777079e5164ca7969ab7c0006b43c6b9e2944db2
Author: Alexis de Talhouët <adetalhouet@inocybe.com>
Date:   2016-11-16T18:39:29Z

    ARIES-1634 BlueprintContainer are leaked when destroyed
    
    While destroying the BlueprintContainer, the associated
    ServiceRegistration isn't unregistered, although it should
    be to completely release the BlueprintContainer.
    
    The #quiesce() method does that correctly, so current workaround
    is to first quiesce the bundle then destroy it. But it feels like
    an oversight in the #destroy() method.
    
    Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>

----


> BlueprintContainer are leaked when destroyed
> --------------------------------------------
>
>                 Key: ARIES-1634
>                 URL: https://issues.apache.org/jira/browse/ARIES-1634
>             Project: Aries
>          Issue Type: Bug
>          Components: Blueprint
>    Affects Versions: blueprint-core-1.4.2
>         Environment: OSx
>            Reporter: Alexis de Talhouët
>              Labels: easyfix
>
> When the BlueprintContainer is #destroy(), it is not unregistered from the OSGi registry
hence is retained in the memory.
> But when the BlueprintContainer is #quiesce() it is correctly unregistered from the OSGi
registry.
> The workaround it to first #quiesce() the container, then #destroy() it, so no service
is retaining it, and it can be GC.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message