aries-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From adetalhouet <...@git.apache.org>
Subject [GitHub] aries pull request #58: ARIES-1634 BlueprintContainer are leaked when destro...
Date Wed, 16 Nov 2016 18:42:25 GMT
GitHub user adetalhouet opened a pull request:

    https://github.com/apache/aries/pull/58

    ARIES-1634 BlueprintContainer are leaked when destroyed

    While destroying the BlueprintContainer, the associated
    ServiceRegistration isn't unregistered, although it should
    be to completely release the BlueprintContainer.
    
    The #quiesce() method does that correctly, so current workaround
    is to first quiesce the bundle then destroy it. But it feels like
    an oversight in the #destroy() method.
    
    Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/adetalhouet/aries blueprint-container-leak

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/aries/pull/58.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #58
    
----
commit 777079e5164ca7969ab7c0006b43c6b9e2944db2
Author: Alexis de Talhouët <adetalhouet@inocybe.com>
Date:   2016-11-16T18:39:29Z

    ARIES-1634 BlueprintContainer are leaked when destroyed
    
    While destroying the BlueprintContainer, the associated
    ServiceRegistration isn't unregistered, although it should
    be to completely release the BlueprintContainer.
    
    The #quiesce() method does that correctly, so current workaround
    is to first quiesce the bundle then destroy it. But it feels like
    an oversight in the #destroy() method.
    
    Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message