aries-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Martin Lichtin (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (ARIES-1193) INFO log when optional service is not available
Date Fri, 15 Jun 2018 10:55:00 GMT

     [ https://issues.apache.org/jira/browse/ARIES-1193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Martin Lichtin updated ARIES-1193:
----------------------------------
    Description: 
Can the log level be reconsidered?

{noformat}
     if (metadata.getAvailability() == ServiceReferenceMetadata.AVAILABILITY_MANDATORY) {
        LOGGER.info("Timeout expired when waiting for mandatory OSGi service reference {}",
getOsgiFilter());
        throw new ServiceUnavailableException("Timeout expired when waiting for mandatory
OSGi service reference: " + getOsgiFilter(), getOsgiFilter());
    } else {
        LOGGER.info("No matching service for optional OSGi service reference {}", getOsgiFilter());
        throw new ServiceUnavailableException("No matching service for optional OSGi service
reference: " + getOsgiFilter(), getOsgiFilter());
    }
{noformat}
I don't see the need to repeatedly emit INFO logs for an optional service not being around.
Can it be changed to DEBUG level?

On the other side, for a mandatory service, the INFO log could become a WARN, perhaps.


  was:
Can the log level be reconsidered?

                    if (metadata.getAvailability() == ServiceReferenceMetadata.AVAILABILITY_MANDATORY)
{
                        LOGGER.info("Timeout expired when waiting for mandatory OSGi service
reference {}", getOsgiFilter());
                        throw new ServiceUnavailableException("Timeout expired when waiting
for mandatory OSGi service reference: " + getOsgiFilter(), getOsgiFilter());
                    } else {
                        LOGGER.info("No matching service for optional OSGi service reference
{}", getOsgiFilter());
                        throw new ServiceUnavailableException("No matching service for optional
OSGi service reference: " + getOsgiFilter(), getOsgiFilter());
                    }

I don't see the need to repeatedly emit INFO logs for an optional service not being around.
Can it be changed to DEBUG level?

On the other side, for a mandatory service, the INFO log could become a WARN, perhaps.



> INFO log when optional service is not available
> -----------------------------------------------
>
>                 Key: ARIES-1193
>                 URL: https://issues.apache.org/jira/browse/ARIES-1193
>             Project: Aries
>          Issue Type: Bug
>            Reporter: Martin Lichtin
>            Assignee: Jean-Baptiste Onofré
>            Priority: Minor
>
> Can the log level be reconsidered?
> {noformat}
>      if (metadata.getAvailability() == ServiceReferenceMetadata.AVAILABILITY_MANDATORY)
{
>         LOGGER.info("Timeout expired when waiting for mandatory OSGi service reference
{}", getOsgiFilter());
>         throw new ServiceUnavailableException("Timeout expired when waiting for mandatory
OSGi service reference: " + getOsgiFilter(), getOsgiFilter());
>     } else {
>         LOGGER.info("No matching service for optional OSGi service reference {}", getOsgiFilter());
>         throw new ServiceUnavailableException("No matching service for optional OSGi
service reference: " + getOsgiFilter(), getOsgiFilter());
>     }
> {noformat}
> I don't see the need to repeatedly emit INFO logs for an optional service not being around.
Can it be changed to DEBUG level?
> On the other side, for a mandatory service, the INFO log could become a WARN, perhaps.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message