atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ashutosh Mestry via Review Board <nore...@reviews.apache.org>
Subject Re: Review Request 72512: Edge Creation: Refactoring
Date Fri, 15 May 2020 17:19:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72512/
-----------------------------------------------------------

(Updated May 15, 2020, 5:19 p.m.)


Review request for atlas.


Changes
-------

Updates include: Addressed review comments.


Bugs: ATLAS-3797
    https://issues.apache.org/jira/browse/ATLAS-3797


Repository: atlas


Description
-------

**Approach**
Modified: _GraphHelper.getOrCreateEdge_ to use _AtlasJanusGraph.getEdgeBetweenVertices_.
Modified: _AtlasJanusGraph.getEdgeBetweenVertices_ modified fetch.


Diffs (updated)
-----

  graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraph.java
35274c9d1 
  repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java b1368e5e9 


Diff: https://reviews.apache.org/r/72512/diff/3/

Changes: https://reviews.apache.org/r/72512/diff/2-3/


Testing
-------

**Pre-commit**
https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1896/

**Volume test**
Case edge creation involves existing entity where large number of existing edges (200K), this
change shows significant improvement.


Thanks,

Ashutosh Mestry


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message