atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ashutosh Mestry via Review Board <nore...@reviews.apache.org>
Subject Re: Review Request 72474: ATLAS-3783 : DSL query search should return results for both the relationship edge directions
Date Fri, 15 May 2020 17:31:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72474/#review220788
-----------------------------------------------------------


Ship it!




Is this change needed at all? What is implemented is correct, since NullPointerException is
caught and added to the errorList.

- Ashutosh Mestry


On May 15, 2020, 12:14 p.m., chaitali wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72474/
> -----------------------------------------------------------
> 
> (Updated May 15, 2020, 12:14 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Nikhil Bonte, Nixon Rodrigues, and Sarath
Subramanian.
> 
> 
> Bugs: ATLAS-3783
>     https://issues.apache.org/jira/browse/ATLAS-3783
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Unable to get results for Dsl query eg;hive_column where table.name="employee".
> Due to regression only one edge direction was giving results.
> This patch gives a fix for results for both relationship edge direction queries.
> Documentation added for this fiv in Advanced DSl search.
> 
> 
> Diffs
> -----
> 
>   repository/src/main/java/org/apache/atlas/query/IdentifierHelper.java 129c20354 
> 
> 
> Diff: https://reviews.apache.org/r/72474/diff/14/
> 
> 
> Testing
> -------
> 
> TestCases added.
> 
> 
> Thanks,
> 
> chaitali
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message