beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (BEAM-162) assert fail using session windows
Date Wed, 06 Apr 2016 16:59:25 GMT


ASF GitHub Bot commented on BEAM-162:

GitHub user mshields822 opened a pull request:

    [BEAM-162] Merging with closed windows less sensitive to bundle partioning

    This change also rejects elements for windows which are closed before merging. 
    (Rejecting elements which end up in a closed window post-merging is still there.)
    Idea is rejecting post-merge is necessary so that we never emit elements for a closed
window, and rejecting pre-merge is necessary so that the result is invariant on bundle repartioning.

     - We want to abandon closable triggers.
     - The notion of invariance on bundle repartioning is already unsupportable for most of
our triggers.
    So I'd be fine if we give up on this one.

You can merge this pull request into a Git repository by running:

    $ git pull beam-162

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #135
commit e1df0f2cdae123df301d2b8cebf42931852fe6b8
Author: Mark Shields <>
Date:   2016-04-05T22:12:16Z

    Formatting fiddles

commit 65874af3abf35eed66976b47f9712eec4e06304c
Author: Mark Shields <>
Date:   2016-04-06T04:20:06Z

    Also reject closed pre-merged.


> assert fail using session windows
> ---------------------------------
>                 Key: BEAM-162
>                 URL:
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-core
>            Reporter: Mark Shields
>            Assignee: Mark Shields
> java.lang.IllegalStateException: Window [2016-03-31T05:35:31.158Z..2016-03-31T06:05:31.158Z)
should have been added
> at
> at
> at
> at
> at
> at
> at
> at
> at
> at
> at

This message was sent by Atlassian JIRA

View raw message