beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-168) IntervalBoundedBackOff change broke Beam-on-Dataflow
Date Mon, 04 Apr 2016 21:42:25 GMT

    [ https://issues.apache.org/jira/browse/BEAM-168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15225112#comment-15225112
] 

ASF GitHub Bot commented on BEAM-168:
-------------------------------------

GitHub user dhalperi opened a pull request:

    https://github.com/apache/incubator-beam/pull/117

    [BEAM-168] IntervalBoundedExponentialBackOff: add deprecated copy of old API

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [X] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [X] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [X] Replace "<Jira issue #>" in the title with the actual Jira issue
           number, if there is one.
     - [X] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    This fixes a bug submitting jobs to Google Cloud Dataflow service.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dhalperi/incubator-beam fix-backoff

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/117.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #117
    
----
commit 2179e8d674d952b606afdfd73e4521e1588ed694
Author: Dan Halperin <dhalperi@google.com>
Date:   2016-04-04T21:40:00Z

    IntervalBoundedExponentialBackOff: add deprecated copy of old API
    
    This fixes a bug submitting jobs to Google Cloud Dataflow service.

----


> IntervalBoundedBackOff change broke Beam-on-Dataflow
> ----------------------------------------------------
>
>                 Key: BEAM-168
>                 URL: https://issues.apache.org/jira/browse/BEAM-168
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-dataflow
>            Reporter: Daniel Halperin
>            Assignee: Daniel Halperin
>
> Changing the `int` to a `long` breaks ABI compatibility, which Dataflow service uses.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message