beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-359) AvroCoder should be able to handle anonymous classes as schemas
Date Tue, 21 Jun 2016 21:01:01 GMT

    [ https://issues.apache.org/jira/browse/BEAM-359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15342676#comment-15342676
] 

ASF GitHub Bot commented on BEAM-359:
-------------------------------------

GitHub user bjchambers opened a pull request:

    https://github.com/apache/incubator-beam/pull/513

    Fix BEAM-359

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [*] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [*] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [*] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [*] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    Rather than throwing an exception when checking determinism of an erased
    generic, record that as a non-determistic class and proceed.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bjchambers/incubator-beam beam-359-avrocode.r

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/513.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #513
    
----
commit 0e656f4df4371fdf6da181ddb984027bce7ec72d
Author: bchambers <bchambers@google.com>
Date:   2016-06-21T20:42:33Z

    Fix BEAM-359
    
    Rather than throwing an exception when checking determinism of an erased
    generic, record that as a non-determistic class and proceed.

----


> AvroCoder should be able to handle anonymous classes as schemas
> ---------------------------------------------------------------
>
>                 Key: BEAM-359
>                 URL: https://issues.apache.org/jira/browse/BEAM-359
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>    Affects Versions: 0.1.0-incubating, 0.2.0-incubating
>            Reporter: Daniel Mills
>            Assignee: Ben Chambers
>
> Currently, the determinism checker NPEs with:
> java.lang.IllegalArgumentException: Unable to get field id from class null
>     at com.google.cloud.dataflow.sdk.coders.AvroCoder$AvroDeterminismChecker.getField(AvroCoder.java:710)
>     at com.google.cloud.dataflow.sdk.coders.AvroCoder$AvroDeterminismChecker.checkRecord(AvroCoder.java:548)
>     at com.google.cloud.dataflow.sdk.coders.AvroCoder$AvroDeterminismChecker.doCheck(AvroCoder.java:477)
>     at com.google.cloud.dataflow.sdk.coders.AvroCoder$AvroDeterminismChecker.recurse(AvroCoder.java:453)
>     at com.google.cloud.dataflow.sdk.coders.AvroCoder$AvroDeterminismChecker.checkRecord(AvroCoder.java:567)
>     at com.google.cloud.dataflow.sdk.coders.AvroCoder$AvroDeterminismChecker.doCheck(AvroCoder.java:477)
>     at com.google.cloud.dataflow.sdk.coders.AvroCoder$AvroDeterminismChecker.recurse(AvroCoder.java:453)
>     at com.google.cloud.dataflow.sdk.coders.AvroCoder$AvroDeterminismChecker.check(AvroCoder.java:430)
>     at com.google.cloud.dataflow.sdk.coders.AvroCoder.<init>(AvroCoder.java:189)
>     at com.google.cloud.dataflow.sdk.coders.AvroCoder.of(AvroCoder.java:144)
>     at mypackage.GenericsTest$1.create(GenericsTest.java:102)
>     at com.google.cloud.dataflow.sdk.coders.CoderRegistry.getDefaultCoderFromFactory(CoderRegistry.java:797)
>     at com.google.cloud.dataflow.sdk.coders.CoderRegistry.getDefaultCoder(CoderRegistry.java:748)
>     at com.google.cloud.dataflow.sdk.coders.CoderRegistry.getDefaultCoder(CoderRegistry.java:719)
>     at com.google.cloud.dataflow.sdk.coders.CoderRegistry.getDefaultCoder(CoderRegistry.java:696)
>     at com.google.cloud.dataflow.sdk.coders.CoderRegistry.getDefaultCoder(CoderRegistry.java:178)
>     at com.google.cloud.dataflow.sdk.values.TypedPValue.inferCoderOrFail(TypedPValue.java:147)
>     at com.google.cloud.dataflow.sdk.values.TypedPValue.getCoder(TypedPValue.java:48)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message