beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tgroh <...@git.apache.org>
Subject [GitHub] incubator-beam pull request #567: Add withAllowedLateness with Closing Behav...
Date Thu, 30 Jun 2016 17:22:12 GMT
GitHub user tgroh opened a pull request:

    https://github.com/apache/incubator-beam/pull/567

    Add withAllowedLateness with Closing Behavior to Window

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    This makes the static constructors for withAllowedLateness symmetric to
    the PTransform builder methods. It also allows references to
    Window#withAllowedLateness(Duration, ClosingBehavior).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/incubator-beam window_closing_behavior_constructor

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/567.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #567
    
----
commit 76a7b0f60a8fc6c041eacd39e10e1d15d121d4e5
Author: Thomas Groh <tgroh@google.com>
Date:   2016-06-30T17:06:52Z

    Add withAllowedLateness with Closing Behavior to Window
    
    This makes the static constructors for withAllowedLateness symmetric to
    the PTransform builder methods. It also allows references to
    Window#withAllowedLateness(Duration, ClosingBehavior).

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message