beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-469) NullableCoder should encode using the context given and not always use the nested context
Date Fri, 14 Oct 2016 17:37:20 GMT

    [ https://issues.apache.org/jira/browse/BEAM-469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15575967#comment-15575967
] 

ASF GitHub Bot commented on BEAM-469:
-------------------------------------

GitHub user tgroh opened a pull request:

    https://github.com/apache/incubator-beam/pull/1104

    [BEAM-469] Remove Remaining Nested Contexts from NullableCoder

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/incubator-beam nullable_non_nested

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1104.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1104
    
----
commit 4e4e9dfd8a24f614da657dd31b64cea2f4f1aa03
Author: Thomas Groh <tgroh@google.com>
Date:   2016-10-14T17:34:55Z

    Remove Remaining Nested Contexts from NullableCoder

----


> NullableCoder should encode using the context given and not always use the nested context
> -----------------------------------------------------------------------------------------
>
>                 Key: BEAM-469
>                 URL: https://issues.apache.org/jira/browse/BEAM-469
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-core
>            Reporter: Luke Cwik
>            Assignee: Thomas Groh
>            Priority: Trivial
>             Fix For: Not applicable
>
>
> NullableCoder should encode using the context given and not always use the nested context.
For coders which can efficiently encode in the outer context such as StringUtf8Coder or ByteArrayCoder,
we are forcing them to prefix themselves with their length.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message