beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-847) DelelgatingAggregator uses UUID.randomUUID, which uses a synchronized Random method
Date Thu, 27 Oct 2016 23:28:58 GMT

    [ https://issues.apache.org/jira/browse/BEAM-847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15613647#comment-15613647
] 

ASF GitHub Bot commented on BEAM-847:
-------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-beam/pull/1210


> DelelgatingAggregator uses UUID.randomUUID, which uses a synchronized Random method
> -----------------------------------------------------------------------------------
>
>                 Key: BEAM-847
>                 URL: https://issues.apache.org/jira/browse/BEAM-847
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-core, runner-dataflow, runner-direct, runner-flink, sdk-java-core
>            Reporter: Thomas Groh
>            Assignee: Thomas Groh
>
> This normally would not be a problem, as users are expected to create Aggregators in
a non-performance-sensitive fashion. {{GroupAlsoByWindowViaWindowSet}} also creates an {{Aggregator}},
and this is a runner-provided {{DoFn}} (and may be created some arbitrary number of times
on workers); this call should not use a shared resource.
> As the IDs of an {{Aggregator}} are used only to ensure that an {{Aggregator}} has a
consistent identity across a serialization boundary, used in the {{AggregatorPipelineExtractor}},
these can be less random so long as they remain mostly unique.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message