beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-854) ReifyTimestampAndWindows explodes windows
Date Fri, 28 Oct 2016 22:19:58 GMT

    [ https://issues.apache.org/jira/browse/BEAM-854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15616766#comment-15616766
] 

ASF GitHub Bot commented on BEAM-854:
-------------------------------------

GitHub user jkff opened a pull request:

    https://github.com/apache/incubator-beam/pull/1225

    [BEAM-854] Removes ReifyTimestampsAndWindows

    It was used effectively in 2 places:
    - GatherAllPanes (used in PAssert): replaced with a similar custom DoFn.
    - A couple of GBK-related transforms: folded into GroupByKeyOnly.
    
    Additionally, makes DirectGroupByKeyOnly produce globally-windowed KeyedWorkItem's - we
already knew this was the right thing to do in general.
    
    R: @tgroh 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jkff/incubator-beam rm-reify

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1225.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1225
    
----
commit 5382fd9b14efca03e8be1d36432bbbfb14b1a9fc
Author: Eugene Kirpichov <kirpichov@google.com>
Date:   2016-10-28T17:40:17Z

    [BEAM-854] Removes ReifyTimestampsAndWindows
    
    It was used effectively in 2 places:
    - GatherAllPanes (used in PAssert):
      replaced with a similar custom DoFn.
    - A couple of GBK-related transforms:
      folded into GroupByKeyOnly.

commit db6dabf44a12168941a34d202adf151b8191825a
Author: Eugene Kirpichov <kirpichov@google.com>
Date:   2016-10-28T22:16:01Z

    Also makes GBKO produce globally-windowed KWIs

----


> ReifyTimestampAndWindows explodes windows
> -----------------------------------------
>
>                 Key: BEAM-854
>                 URL: https://issues.apache.org/jira/browse/BEAM-854
>             Project: Beam
>          Issue Type: Bug
>            Reporter: Eugene Kirpichov
>            Assignee: Kenneth Knowles
>
> Commit https://github.com/apache/incubator-beam/commit/b2350417f73ae6c34f849ff0e93d5bd93df3088d
changed the fn from accessing the collection of windows to accessing the windows one-by-one,
which causes this DoFn to explode them, which (I suppose) hurts performance, since this Fn
is quite important: it's a part of GroupByKey in the Spark runner and Direct runner, part
of Splittable DoFn, part of GBKViaGBKO, and part of GatherAllPanes.
> I can see a couple of ways to fix this:
> - Make this be a primitive transform, with runner-specific support to keep the windows
compressed
> - Allow any DoFn to access the compressed representation explicitly using a Collection<BoundedWindow>
parameter
> I'm personally in favor of the latter because it automatically benefits all runners.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message