beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From k...@apache.org
Subject [1/2] incubator-beam git commit: Place fired timers in the Global Window
Date Wed, 05 Oct 2016 20:06:05 GMT
Repository: incubator-beam
Updated Branches:
  refs/heads/master e46127e5a -> 5918fed8a


Place fired timers in the Global Window

The runner is theoretically permitted to drop timers it recieves if they
are not present in any window. This ensures that any element provided to
any TransformEvaluator by the runner (not user-assigned windows) is in
at least one window.


Project: http://git-wip-us.apache.org/repos/asf/incubator-beam/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-beam/commit/8d659fec
Tree: http://git-wip-us.apache.org/repos/asf/incubator-beam/tree/8d659fec
Diff: http://git-wip-us.apache.org/repos/asf/incubator-beam/diff/8d659fec

Branch: refs/heads/master
Commit: 8d659fec13982c982d58d8abd1007197bc443c61
Parents: 087dcef
Author: Thomas Groh <tgroh@google.com>
Authored: Mon Aug 22 13:27:33 2016 -0700
Committer: Thomas Groh <tgroh@google.com>
Committed: Wed Oct 5 10:00:50 2016 -0700

----------------------------------------------------------------------
 .../beam/runners/direct/ExecutorServiceParallelExecutor.java       | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/8d659fec/runners/direct-java/src/main/java/org/apache/beam/runners/direct/ExecutorServiceParallelExecutor.java
----------------------------------------------------------------------
diff --git a/runners/direct-java/src/main/java/org/apache/beam/runners/direct/ExecutorServiceParallelExecutor.java
b/runners/direct-java/src/main/java/org/apache/beam/runners/direct/ExecutorServiceParallelExecutor.java
index 9e11f6d..53e03c8 100644
--- a/runners/direct-java/src/main/java/org/apache/beam/runners/direct/ExecutorServiceParallelExecutor.java
+++ b/runners/direct-java/src/main/java/org/apache/beam/runners/direct/ExecutorServiceParallelExecutor.java
@@ -423,7 +423,7 @@ final class ExecutorServiceParallelExecutor implements PipelineExecutor
{
               CommittedBundle<?> bundle =
                   evaluationContext
                       .createKeyedBundle(keyTimers.getKey(), (PCollection) transform.getInput())
-                      .add(WindowedValue.valueInEmptyWindows(work))
+                      .add(WindowedValue.valueInGlobalWindow(work))
                       .commit(evaluationContext.now());
               scheduleConsumption(transform, bundle, new TimerIterableCompletionCallback(delivery));
               state.set(ExecutorState.ACTIVE);


Mime
View raw message