beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kennknowles <>
Subject [GitHub] incubator-beam pull request #1044: [BEAM-25] Refactor StateSpec out of State...
Date Tue, 04 Oct 2016 18:53:44 GMT
GitHub user kennknowles opened a pull request:

    [BEAM-25] Refactor StateSpec out of StateTag

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](
    R: @aljoscha AND @tgroh AND @bjchambers 
    This is a rebase of #793 without much cleanup. The same commentary applies - I'm not totally
happy with it but I want to ask for feedback.

You can merge this pull request into a Git repository by running:

    $ git pull StateSpec

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1044
commit 1f2de1e1212cbdb5eb3c8cb7caf30b94da5e0b00
Author: Kenneth Knowles <>
Date:   2016-08-05T03:50:28Z

    Create StateSpec parallel to StateTag

commit 6fa680858719eaf13edcc08aa3f3260584876fb5
Author: Kenneth Knowles <>
Date:   2016-08-05T04:48:48Z

    Make StateTag carry a StateSpec separately from its id


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message