beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kennknowles <>
Subject [GitHub] incubator-beam pull request #1103: Remove "OrParse" from DoFnSignatures.getS...
Date Fri, 14 Oct 2016 15:51:16 GMT
GitHub user kennknowles opened a pull request:

    Remove "OrParse" from DoFnSignatures.getSignature

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](
    R: @bjchambers

You can merge this pull request into a Git repository by running:

    $ git pull getOrNothing

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1103
commit c07f91a3f0a722ded5a667acfba3fdf2dce155cb
Author: Kenneth Knowles <>
Date:   2016-10-14T15:48:49Z

    Remove "OrParse" from DoFnSignatures.getSignature
    This excessive verbosity is also an abstraction violation. It
    is an implementation detail how the signature is gotten.


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message