beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kennknowles <...@git.apache.org>
Subject [GitHub] incubator-beam pull request #1216: [BEAM-854] Directly implement ReifyTimest...
Date Fri, 28 Oct 2016 05:24:16 GMT
GitHub user kennknowles opened a pull request:

    https://github.com/apache/incubator-beam/pull/1216

    [BEAM-854] Directly implement ReifyTimestampsAndWindows in SparkRunner

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    R: @amitsela 
    
    I introduced a performance issue in [BEAM-854](https://issues.apache.org/jira/browse/BEAM-854)
that affects the SparkRunner and DirectRunner. As per discussion there, `ReifyTimestampsAndWindows`
can only use the multi-window `WindowedValue` representation if it is implemented as a primitive.
The fix is pretty trivial, and actually just simpler anyhow. I ran `mvn integration-test -Plocal-runnable-on-service-tests
-pl runners/spark` but feel free to pull this down and do it right if I have missed something,
inline the class, etc, whatever you like.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/incubator-beam Spark-Reify

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1216.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1216
    
----
commit 72b634857bc660716a1ce5e8fa03b39138472652
Author: Kenneth Knowles <klk@google.com>
Date:   2016-10-28T05:18:19Z

    Directly implement ReifyTimestampsAndWindows in SparkRunner

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message