beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From swegner <>
Subject [GitHub] incubator-beam pull request #1218: Remove unnecessary configuration properti...
Date Fri, 28 Oct 2016 16:24:52 GMT
GitHub user swegner opened a pull request:

    Remove unnecessary configuration properties from checkstyle.xml

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](
    Is there any reason we need these properties? The default values are not overridden anywhere
in our project and would lead to inconsistent style enforcement.

You can merge this pull request into a Git repository by running:

    $ git pull checkstyle-intellij

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1218
commit 7a0a8207878e8316f416ab1a1429c051d2ac7470
Author: Scott Wegner <>
Date:   2016-10-28T16:17:46Z

    Remove unnecessary configuration properties from checkstyle.xml


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message