beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [beam] acrites commented on issue #10988: [BEAM-9382] Clean up of TestStreamTranscriptTests.
Date Tue, 03 Mar 2020 03:52:46 GMT
acrites commented on issue #10988: [BEAM-9382] Clean up of TestStreamTranscriptTests.
URL: https://github.com/apache/beam/pull/10988#issuecomment-593753721
 
 
   Along the lines of what Kenn is saying, I had originally thought that these tests weren't
really testing whether or not PaneInfo.final gets set correctly in the various triggering
strategies, but more so that it was outputting the correct elements. Maybe we want to test
all aspects in a single test though.
   
   I'm fine with sickbaying the tests for Python direct runner if you're ok with having a
large number of tests inactive until we getting around to fixing direct runner. Maybe that'll
motivate us to get it fixed faster...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message