beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [beam] robertwb commented on issue #10988: [BEAM-9382] Clean up of TestStreamTranscriptTests.
Date Fri, 06 Mar 2020 19:45:03 GMT
robertwb commented on issue #10988: [BEAM-9382] Clean up of TestStreamTranscriptTests.
URL: https://github.com/apache/beam/pull/10988#issuecomment-595930667
 
 
   The Python direct runner does support PaneInfo, but it doesn't (yet) support allowed lateness,
so the "final" bit is wrong. Yes, we should fix this, though hopefully on the FnApiRunner
once it supports streaming rather than invest too much into the old direct runner (unless
it's cheap to do). 
   
   I would rather disable the "final" bit check for these tests (and add a new, disabled test
that checks this bit) than disable these tests entirely for the direct runner. So as is, this
change LGTM.
   
   We could also consider expanding the API to indicate certain features are broken on certain
runners, rather than entire tests, which would allow us to fully specify the expected results
and still produce partial validation on incomplete/in-progress runners. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message