beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [beam] robertwb commented on a change in pull request #11005: [BEAM-8335] Modify the StreamingCache to subclass the CacheManager
Date Fri, 06 Mar 2020 20:16:50 GMT
robertwb commented on a change in pull request #11005: [BEAM-8335] Modify the StreamingCache
to subclass the CacheManager 
URL: https://github.com/apache/beam/pull/11005#discussion_r389122984
 
 

 ##########
 File path: sdks/python/apache_beam/runners/direct/transform_evaluator.py
 ##########
 @@ -421,8 +440,12 @@ def process_element(self, element):
       main_output = list(self._outputs)[0]
       bundle = self._evaluation_context.create_bundle(main_output)
       for tv in event.timestamped_values:
-        bundle.output(
-            GlobalWindows.windowed_value(tv.value, timestamp=tv.timestamp))
+        # Unreify the value into the correct window.
+        try:
+          bundle.output(WindowedValue(**tv.value))
 
 Review comment:
   Alternatively, it might be cleaner to just pass the test stream event proto here rather
than decoding it and then interpreting it. (Maybe this'd be a larger change.)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message