beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [beam] robertwb commented on a change in pull request #11005: [BEAM-8335] Modify the StreamingCache to subclass the CacheManager
Date Fri, 06 Mar 2020 21:02:05 GMT
robertwb commented on a change in pull request #11005: [BEAM-8335] Modify the StreamingCache
to subclass the CacheManager 
URL: https://github.com/apache/beam/pull/11005#discussion_r389131463
 
 

 ##########
 File path: sdks/python/apache_beam/runners/direct/direct_runner.py
 ##########
 @@ -408,7 +410,8 @@ def visit_transform(self, applied_ptransform):
         self.consumer_tracking_visitor.value_to_consumers,
         self.consumer_tracking_visitor.step_names,
         self.consumer_tracking_visitor.views,
-        clock)
+        clock,
+        test_stream_visitor.endpoint)
 
 Review comment:
   Why is this passed via the context, instead of accessed directly on the test stream object
when it is being processed? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message