beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [beam] ecapoccia commented on issue #11037: [BEAM-9434] performance improvements reading many Avro files in S3
Date Fri, 06 Mar 2020 21:59:17 GMT
ecapoccia commented on issue #11037: [BEAM-9434] performance improvements reading many Avro
files in S3
URL: https://github.com/apache/beam/pull/11037#issuecomment-595982928
 
 
   > Adding a filesystem API that all filesystems need to implement is going to raise some
questions in the Apache Beam community. Asked some follow-ups on BEAM-9434 to see if the issue
is localized to Spark.
   
   @lukecwik Ok I see.
   
   Technically speaking, it is not *mandatory* to implement in every filesystem, but effectively
in order to properly support the hint in every filesystem it is.
   
   I considered a few alternatives:
   - the current one, throwing an UnsupportedOperationException if a filesystem does not support
it
   - a default implementation that does a wasteful filtering before returning the results
(not scalable)
   - implementing it for all filesystem
   
   The reality is, I haven't got a mean of testing the last option on anything else than S3,
otherwise the last option is the best approach imho.
   
   Let me know what are the opinions. 
   
   Also, looks like to me that the filesystems classes are internal to the framework, not
supposed to be used directly by end users. In which case *maybe* another option is viable,
which is renaming appropriately the new hint, and don't make it mandatory by means of the
framework to consider the hint.
   
   In other words, I'm saying that we can hint to use N partitions, but the runtime can just
ignore the hint if that's not supported by the underlying filesystem.
   I can modify the code in this way if that's viable. 
   
   Happy to hear back from you guys, and thanks for the feedback.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message