beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [beam] mxm commented on a change in pull request #11084: [BEAM-9474] Improve robustness of BundleFactory and ProcessEnvironment
Date Wed, 11 Mar 2020 20:43:52 GMT
mxm commented on a change in pull request #11084: [BEAM-9474] Improve robustness of BundleFactory
and ProcessEnvironment
URL: https://github.com/apache/beam/pull/11084#discussion_r391256990
 
 

 ##########
 File path: runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/control/DefaultJobBundleFactory.java
 ##########
 @@ -352,20 +407,18 @@ public RemoteBundle getBundle(
         // The blocking queue of caches for serving multiple bundles concurrently.
         currentCache = availableCaches.take();
         client = currentCache.getUnchecked(executableStage.getEnvironment());
-        client.ref();
 
 Review comment:
   Yes, that makes sense. I've already reverted the change.
   
   I suppose there is a race condition where we retrieve an environment X and before we can
call `ref()` on it, we evict the environment X, close all its references, and shut it down.
This will result in a job restart.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message