beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [beam] reuvenlax commented on a change in pull request #11154: [BEAM-1819] Key should be available in @OnTimer methods
Date Mon, 23 Mar 2020 16:47:23 GMT
reuvenlax commented on a change in pull request #11154: [BEAM-1819] Key should be available
in @OnTimer methods
URL: https://github.com/apache/beam/pull/11154#discussion_r396597515
 
 

 ##########
 File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/reflect/DoFnSignatures.java
 ##########
 @@ -1282,6 +1283,14 @@ private static Parameter analyzeExtraParameter(
           rawType.equals(Instant.class),
           "@Timestamp argument must have type org.joda.time.Instant.");
       return Parameter.timestampParameter();
+    } else if (hasAnnotation(DoFn.KeyId.class, param.getAnnotations())) {
+      Type keyType = ((ParameterizedType) inputT.getType()).getActualTypeArguments()[0];
 
 Review comment:
   I think we also need to verify that the input type is a KV

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message