beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [beam] reuvenlax commented on a change in pull request #11154: [BEAM-1819] Key should be available in @OnTimer methods
Date Mon, 23 Mar 2020 16:47:23 GMT
reuvenlax commented on a change in pull request #11154: [BEAM-1819] Key should be available
in @OnTimer methods
URL: https://github.com/apache/beam/pull/11154#discussion_r396595875
 
 

 ##########
 File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/DoFn.java
 ##########
 @@ -481,6 +481,12 @@ public Duration getAllowedTimestampSkew() {
     String value();
   }
 
+  /** Parameter annotation for the input element key for {@link OnTimer} methods. */
 
 Review comment:
   I think should just be named Key, not KeyId.
   
   Also I wouldn't reference OnTimer here, as @Key also makes sense in processElement (instead
of getting a KV you should be able to get they key and the value in separate parameters.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message