beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [beam] kamilwu commented on a change in pull request #11086: [BEAM-8910] Make custom BQ source read from Avro
Date Mon, 23 Mar 2020 17:47:07 GMT
kamilwu commented on a change in pull request #11086: [BEAM-8910] Make custom BQ source read
from Avro
URL: https://github.com/apache/beam/pull/11086#discussion_r396638710
 
 

 ##########
 File path: sdks/python/apache_beam/io/gcp/bigquery_read_it_test.py
 ##########
 @@ -69,6 +70,20 @@ def wrapped(self):
   return inner
 
 
+def datetime_to_utc(element):
+  for k, v in element.items():
+    if isinstance(v, datetime.time):
 
 Review comment:
   We can combine this condition with the one below:
   `if isinstance(v, datetime.time) or isinstance(v, datetime.date):`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message