beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [beam] suztomo commented on a change in pull request #11156: [BEAM-9444] Use GCP Libraries BOM for Google Cloud Dependencies
Date Mon, 23 Mar 2020 17:58:23 GMT
suztomo commented on a change in pull request #11156: [BEAM-9444] Use GCP Libraries BOM for
Google Cloud Dependencies
URL: https://github.com/apache/beam/pull/11156#discussion_r396647354
 
 

 ##########
 File path: buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
 ##########
 @@ -444,45 +439,46 @@ class BeamModulePlugin implements Plugin<Project> {
         commons_lang3                               : "org.apache.commons:commons-lang3:3.9",
         commons_math3                               : "org.apache.commons:commons-math3:3.6.1",
         error_prone_annotations                     : "com.google.errorprone:error_prone_annotations:2.0.15",
-        gax                                         : "com.google.api:gax:$gax_version",
-        gax_grpc                                    : "com.google.api:gax-grpc:$gax_version",
+        gax                                         : "com.google.api:gax",
+        gax_grpc                                    : "com.google.api:gax-grpc",
         google_api_client                           : "com.google.api-client:google-api-client:$google_clients_version",
         google_api_client_jackson2                  : "com.google.api-client:google-api-client-jackson2:$google_clients_version",
         google_api_client_java6                     : "com.google.api-client:google-api-client-java6:$google_clients_version",
-        google_api_common                           : "com.google.api:api-common:1.8.1",
+        google_api_common                           : "com.google.api:api-common",
 
 Review comment:
   Added the link and comments ` // google_cloud_platform_libraries_bom sets version`. They
may look too verbose, but they'll help future question "_where is the version of this artifact?_",
especially when we start using other BOMs than GCP Libraries BOM in future.
   
   
   > Beam will depend on that exact list of dependencies shown in that dashboard.
   
   Not exact list. Beam will pick up the version from the BOM for Maven artifacts without
a version. 
   For example,
   - Beam will depend on the BOM's gax version "1.54.0", because Beam's dependency `com.google.api:gax`
does not specify a version.
   - Beam **will not** depend on the BOM's Guava version "28.2-android", because Beam explicitly
specify Guava's version "25.1-jre" as in `com.google.guava:guava:$guava_version`.
   - Beam **will not** depend on the BOM's `com.google.http-client:google-http-client-apache-v2:1.34.2`,
because Beam does not depend on `com.google.http-client:google-http-client-apache-v2`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message