beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [beam] lostluck commented on a change in pull request #11188: [BEAM-3301] Adding restriction trackers and validation.
Date Mon, 23 Mar 2020 23:02:49 GMT
lostluck commented on a change in pull request #11188: [BEAM-3301] Adding restriction trackers
and validation.
URL: https://github.com/apache/beam/pull/11188#discussion_r396795769
 
 

 ##########
 File path: sdks/go/pkg/beam/core/graph/fn_test.go
 ##########
 @@ -676,39 +737,77 @@ func (fn *BadSdfElementTRestSize) RestrictionSize(float32, RestT) float64
{
 type BadRestT struct{}
 
 type BadSdfRestTSplitRestParam struct {
-	*GoodDoFn
+	*GoodSdf
 }
 
 func (fn *BadSdfRestTSplitRestParam) SplitRestriction(int, BadRestT) []RestT {
 	return []RestT{}
 }
 
 type BadSdfRestTSplitRestReturn struct {
-	*GoodDoFn
+	*GoodSdf
 }
 
 func (fn *BadSdfRestTSplitRestReturn) SplitRestriction(int, RestT) []BadRestT {
 	return []BadRestT{}
 }
 
 type BadSdfRestTRestSize struct {
-	*GoodDoFn
+	*GoodSdf
 }
 
 func (fn *BadSdfRestTRestSize) RestrictionSize(int, BadRestT) float64 {
 	return 0
 }
 
+type BadSdfRestTCreateTracker struct {
+	*GoodSdf
+}
+
+func (fn *BadSdfRestTCreateTracker) CreateTracker(BadRestT) *RTrackerT {
+	return &RTrackerT{}
+}
+
 // Examples of other type validation that needs to be done.
 
 type BadSdfRestSizeReturn struct {
-	*GoodDoFn
+	*GoodSdf
 }
 
 func (fn *BadSdfRestSizeReturn) BadSdfRestSizeReturn(int, RestT) int {
 	return 0
 }
 
+type BadRTrackerT struct{}
 
 Review comment:
   Consider commenting that this "RTracker" isn't implementing the RTracker interface.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message