beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [beam] pabloem commented on a change in pull request #11163: [BEAM-9548] Add better error handling to the TestStreamServiceController
Date Mon, 23 Mar 2020 23:07:01 GMT
pabloem commented on a change in pull request #11163: [BEAM-9548] Add better error handling
to the TestStreamServiceController
URL: https://github.com/apache/beam/pull/11163#discussion_r396766986
 
 

 ##########
 File path: sdks/python/apache_beam/runners/interactive/caching/streaming_cache.py
 ##########
 @@ -166,13 +169,15 @@ def _wait_until_file_exists(self, timeout_secs=30):
 
     # Wait for up to `timeout_secs` for the file to be available.
     start = time.time()
-    path = os.path.join(self._cache_dir, *self._labels)
-    while not os.path.exists(path):
+    while not os.path.exists(self._path):
       time.sleep(1)
       if time.time() - start > timeout_timestamp_secs:
+        from apache_beam.runners.interactive.pipeline_instrument import CacheKey
+        pcollection_var = CacheKey.from_str(self._labels[-1]).var
 
 Review comment:
   I hadn't stopeed to think that labels are a file name too, huh? I guess the final file
name is the PCollection variable name? If so, users may name their PCollections something
that is not supported by the OS? (or maybe not since they have to be Python variable names?)
   Anyway this is not for this PR. But just to think about.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message