beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [beam] kamilwu commented on a change in pull request #11194: [BEAM-9507] Fix python dependency check task
Date Tue, 24 Mar 2020 09:42:27 GMT
kamilwu commented on a change in pull request #11194: [BEAM-9507] Fix python dependency check
task
URL: https://github.com/apache/beam/pull/11194#discussion_r397019242
 
 

 ##########
 File path: sdks/python/build.gradle
 ##########
 @@ -89,6 +89,7 @@ task depSnapshot {
 
 task dependencyUpdates {
   dependsOn ':dependencyUpdates'
+  dependsOn buildPython
 
 Review comment:
   I think this tasks does not install all dependencies we need. 
   
   We'd like to install all extras (there are currently five of them: docs, test, gcp, interactive,
aws. You can see them in `setup.py`)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message