beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [beam] reuvenlax opened a new pull request #11074: Store logical type values in Row instead of base values
Date Mon, 09 Mar 2020 04:30:36 GMT
reuvenlax opened a new pull request #11074: Store logical type values in Row instead of base
values
URL: https://github.com/apache/beam/pull/11074
 
 
   @kanterov @alexvanboxel I believe this PR will fix the issues you've both had with logical
types.
   
   After some thought, I think we're better off storing the logical type value in the Row
object. It potentially makes SchemaCoder a tiny bit slower, but unlikely this is noticeable.
One bonus: it means that storage for OneOf types is far more memory efficient, as we no longer
need to store the entire row.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message