buildr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lacton <lac...@users.sourceforge.net>
Subject Re: Current Rakefile is broken
Date Sat, 20 Sep 2008 09:20:17 GMT
Reading your proposed patch, I get the feeling that if we try to
support simultaneously rake 0.8.1 and rake 0.8.2, the code won't be as
clean and simple as it is now.

If possible, I'd rather we adopt an all-or-nothing approach.  Either
we support rake 0.8.1 only, or we fully migrate the trunk to rake
0.8.2.

I'd like to hear others' opinions about this issue.

Lacton

On Fri, Sep 19, 2008 at 3:51 PM, Eung-ju Park <eungju@gmail.com> wrote:
> I have investigated changes of rake 0.8.2. Behavior of
> Rake::Application#have_rakefile was changed.
>
> Below patch would be helpful to build buildr with rake 0.8.2.
>
> Index: lib/buildr/core/application.rb
> ===================================================================
> --- lib/buildr/core/application.rb      (revision 697069)
> +++ lib/buildr/core/application.rb      (working copy)
> @@ -225,10 +225,20 @@
>       @gems = installed
>     end
>
> +    # In rake 0.8.2 have_rakefile returns location of rakefile. It doesn't
> set @rakefile
> +    def have_buildfile
> +      location_or_boolean = have_rakefile
> +      if location_or_boolean.kind_of? String
> +        @rakefile = location_or_boolean
> +        return !@rakefile.nil?
> +      end
> +      location_or_boolean
> +    end
> +
>     def find_buildfile
>       here = original_dir
>       Dir.chdir(here) unless Dir.pwd == here
> -      while ! have_rakefile
> +      while ! have_buildfile
>         Dir.chdir('..')
>         if Dir.pwd == here || options.nosearch
>           error = "No Buildfile found (looking for: #{@rakefiles.join(',
> ')})"
>
>
> On Sun, Sep 14, 2008 at 2:11 AM, lacton <lacton@users.sourceforge.net>wrote:
>
>> On Sat, Sep 13, 2008 at 6:58 PM, Eung-ju Park <eungju@gmail.com> wrote:
>> > I guess two changes makes buildr can't work with rake 0.8.2.
>> >
>> > 1.
>> >
>> http://github.com/jimweirich/rake/commit/68303da1aeda78533c044f2a01a99a619fdb1932Prerequisites
>> > are no longer FileLists
>> >
>> > 2.
>> >
>> http://github.com/jimweirich/rake/commit/41a334b4e6bd3175202675ad289668f457ef73a9Applied
>> > optparse patch
>> > Buildr::Application extends Rake::Application. In rake 0.8.2,
>> command-line
>> > argument parsing has changed. So there is some mismatch.
>>
>> Thanks for the information.  It looks like migrating buildr to rake
>> 0.8.2 will take some time.
>>
>> Lacton
>>
>
>
>
> --
> * LukeSkywalker: Is the dark side stronger?
> * MasterYoda: No...no...no. Quicker, easier, more seductive.

Mime
View raw message