buildr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Antoine Toulme <anto...@toulme.name>
Subject Re: Pull request to add Kotlin support
Date Wed, 26 Jul 2017 15:42:35 GMT
I wasn’t sure either. It looks like we have done that in the past.

Most of the specs are a copy/paste and a little bit of adaptation from Scala compiler specs.

I amended the commit over time and added docs.
I also looked at supporting kotlintest, same way we support scalatest. However, it turned
out to be a thin wrapper/runner for JUnit. I’ll try to use the test framework some more
before I make more changes.

> On Jul 26, 2017, at 4:00 AM, Peter Donald <peter@realityforge.org> wrote:
> 
> Hi,
> 
> I have not used Kotlin before so I just eyeballed the code and looks good.
> I do like that there is good test coverage ;)
> 
> The one thing that I did go eh? at was checking in .class files although I
> know we do it for some other addons (nailgun?, testng test filter?). I do
> wonder whether we could get away with not doing that. But other than that I
> like!
> 
> 
> On Wed, Jul 26, 2017 at 3:17 AM, Antoine Toulme <antoine@toulme.name> wrote:
> 
>> Looks like I need to massage the code to work with JRuby.
>> 
>>> On Jul 24, 2017, at 10:30 PM, Peter Donald <peter@realityforge.org>
>> wrote:
>>> 
>>> Neat ... I will try and have a look towards the end of the week
>>> 
>>> On Mon, Jul 24, 2017 at 4:28 PM, Antoine Toulme <antoine@toulme.name>
>> wrote:
>>> 
>>>> Hello folks,
>>>> 
>>>> Would anybody have time to review my changes to support adding Kotlin to
>>>> the mix of languages we support?
>>>> 
>>>> https://github.com/apache/buildr/pull/26 <https://github.com/apache/
>>>> buildr/pull/26>
>>>> 
>>>> The patch needs polishing, especially docs and handling all the
>> arguments
>>>> the Kotlin compiler provides.
>>>> 
>>>> Cheers,
>>>> 
>>>> Antoine
>>> 
>>> 
>>> 
>>> 
>>> --
>>> Cheers,
>>> 
>>> Peter Donald
>> 
>> 
> 
> 
> -- 
> Cheers,
> 
> Peter Donald


Mime
View raw message