buildr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From croes <...@git.apache.org>
Subject [GitHub] buildr pull request #29: java command: escape classpath entries in the pathi...
Date Tue, 17 Oct 2017 08:14:35 GMT
GitHub user croes opened a pull request:

    https://github.com/apache/buildr/pull/29

    java command: escape classpath entries in the pathing jar manifest

    Hi,
    
    I noticed that the java command fails when using long classpaths on windows, while the
classpath also has entries that contain spaces.
    
    The issue is that the manifest in the pathing jar uses space as a separator between classpath
entries, and entries aren't URI-encoded. A classpath entry with a space in it is incorrectly
treated as 2 entries.
    
    PR is for an older revision, as we use buildr 1.4 internally. It should be easy enough
to merge though, as it's a one-liner fix.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/luciad/buildr luciad_jar_classpath_url_encoding

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/buildr/pull/29.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #29
    
----
commit b6520a7801dbbc4d61b78e5f03545392efddff60
Author: Glenn Croes <glenncroes@gmail.com>
Date:   2017-10-16T11:00:48Z

    java command: escape classpath entries in the pathing jar manifest

----


---

Mime
View raw message