calcite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Muhammad Gelbana <m.gelb...@gmail.com>
Subject Re: Breaking changes and internal APIs
Date Tue, 07 May 2019 14:32:26 GMT
Good subject !

I don't know if we have clear boundaries for internal and external APIs. If
we do, committers can clarify within a Jira if it's breaking an API.

Thanks,
Gelbana


On Tue, May 7, 2019 at 3:17 PM Stamatis Zampetakis <zabetak@gmail.com>
wrote:

> Hello,
>
> While doing code-reviews there are times that I observe changes (let's
> assume that they are meaningful and inevitable) to public
> classes/methods/fields that could break clients if they are relying on
> them.
> In some cases, the changes may occur in some internal APIs that it is
> rather unlikely to be used by clients; still the classes are public and
> accessible.
> I was thinking that even then it is worth adding a few words in the release
> note but maybe I am going too far.
>
> I was wondering if there is a common agreement on this topic.
>
> Best,
> Stamatis
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message