cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Ellis (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CASSANDRA-941) Replace InetAddress usage with EndPoint
Date Tue, 06 Apr 2010 15:47:34 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854025#action_12854025
] 

Jonathan Ellis commented on CASSANDRA-941:
------------------------------------------

Disagree about wrapping ISA.  We shouldn't be relying on toString anywhere (possibly ReadRepairPerformer.callMe
does?  That should not be taking a String param anyway).  All the other places I saw using
the String constructor are dealing w/ user input, and should be split to host, port for principle-of-least-surprise.

More generally, the concept of "endpoint" is one of an immutable struct, adding "methods that
do stuff" to an EndPoint class is a bad fit.

> Replace InetAddress usage with EndPoint
> ---------------------------------------
>
>                 Key: CASSANDRA-941
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-941
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: Core
>            Reporter: Johan Oskarsson
>         Attachments: CASSANDRA-941.patch, CASSANDRA-941.patch
>
>
> An end point should be represented by both address and port instead of port. Create an
EndPoint class that takes an InetAddress and port and use this where needed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message