cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Todd Blose (JIRA)" <>
Subject [jira] Commented: (CASSANDRA-714) remove keyspace argument from thrift methods
Date Thu, 22 Apr 2010 04:34:50 GMT


Todd Blose commented on CASSANDRA-714:

Here's a more detailed account of the other issue:

login previously checked that a keyspace exists. But since we want to use login to authenticate
keyspace creation, this is no longer possible. 

Here's how I resolved this:
checkLoginAuthorized will now verify the keyspace exists. If not, it'll throw an exception
prompting the user to create the keyspace or login to a valid one.
system_add_keyspace can't call checkLoginAuthorized (because its called before the keyspace
is created), but I now check for successful login.

Finally, I had to update once more to login before the sample keyspaces
are created.
Patch attached.

> remove keyspace argument from thrift methods
> --------------------------------------------
>                 Key: CASSANDRA-714
>                 URL:
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.6
>            Reporter: Eric Evans
>            Assignee: Todd Blose
>             Fix For: 0.7
>         Attachments: 0001-CASSANDRA-714.-rm-keyspace-argument-from-thrift-meth.patch,
CASSANDRA-714.access.level.patch, CASSANDRA-714.hadoop.patch, CASSANDRA-714.patch,,
CASSANDRA-714_python_tests.patch, CASSANDRA-714_server.patch, CASSANDRA-714_thrift_def.patch
> With the completion of CASSANDRA-547, the keyspace can be specified as part of the login
and stored in a thread-local. This will allow us to remove the wasteful and redundant mandatory
keyspace argument on all of the other rpc methods.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message